Refactor/1229 #59
Merged
Refactor/1229 #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om the API: Changes made: allocationAdapter.ts - Now uses percentage_of_portfolio directly from API instead of calculating relative percentages AllocationBars.tsx - Each bar now has width: asset.value% (absolute) instead of flex: asset.value (relative) Tests added: 2 new tests in AllocationBars.test.tsx - verify absolute width percentages 6 new tests in allocationAdapter.test.ts - verify API percentages are used correctly All 26 tests passing (20 + 6) Now the bars will show exactly what the API returns: BTC: 37.25% ETH: 17.07% ALT: 10.06% Stables: 35.62%
Updated TargetAllocationBar and PortfolioComposition to use it. Deleted PortfolioLegend. Verified changes with tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.