more accurate error message #23
Open
+59
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I've run the tests on this and it doesn't cause regressions. I like the fact that it also adds a bunch of test cases. I'd vote for merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @youmark,
In issue #17, @Fire1nRain seemed confused by the error message "only PKCS#5 v2.0 supported". Indeed, the error occured, not because PKCS#5 v2.0 was not supported - based on the meta data, that private key seemed encrypted using PKCS#5 v2.0 - but because he passed an invalid ASN1 block - most likely, as @conradoplg mentioned, the raw PEM he read from the file - which is why asn1.Unmarshal failed.
So, I suggest this change to the error message (1) to be consistent with the error message returned by x509.ParsePKCS8PrivateKey when asn1.Unmarshal fails and (2) to help developers who inadvertently passed an invalid ASN1 and think it is a bug.
Hope that helps clarify things. Thanks for this library, very helpful.
Regards,
Philippe.