Promote big constants for arithmetic operations. #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds promotion for big constants in Lua's arithmetic operations. For this we change
op_arithKby inliningop_arith_auxand addingyk_promoteto the second operand.Using the following lua program I can confirm that this indeed promotes big constants:
However, when running
yk-benchmarksI cannot see any significant performance improvements. On the contrarybigloopandpermutetake a 10% performance hit. Looking intobigloopI cannot figure out where this performance hit comes from as the jit-asm of both traces is nearly identical, andYKD_STATStells us that it is indeed trace execution that takes the hit. I've attached the output for a normal run of bigloop and a run with the new promote code, printing outjit-pre-op,jit-asm, andYKD_STATS.NORMAL.txt
PROMOTEK.txt