-
Notifications
You must be signed in to change notification settings - Fork 742
Separate DeleteQueue to allow reusing only current-generation locators #30261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate DeleteQueue to allow reusing only current-generation locators #30261
Conversation
|
🟢 |
|
⚪ ⚪ DetailsYa make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
b9e1b29 to
b2ca408
Compare
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
mregrock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…sing only current-generation locators (#30272)
…ng only current-generation locators (#30271)
Changelog entry
Separate DeleteQueue to allow reusing only current-generation locators
Changelog category
Description for reviewers
This patch removes possibility for potential data race occuring with previous-generation agent trying to write blob that is being collected with fresh-generation BlobDepot (which may be reused and contain inconsistent data as a result).