Skip to content

Conversation

@alexvru
Copy link
Collaborator

@alexvru alexvru commented Dec 6, 2025

Changelog entry

Separate DeleteQueue to allow reusing only current-generation locators

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

This patch removes possibility for potential data race occuring with previous-generation agent trying to write blob that is being collected with fresh-generation BlobDepot (which may be reused and contain inconsistent data as a result).

@ydbot
Copy link
Collaborator

ydbot commented Dec 6, 2025

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

🟢 2025-12-06 14:47:58 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

2025-12-06 14:48:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 632c457 has started.
2025-12-06 14:49:04 UTC Artifacts will be uploaded here
2025-12-06 14:51:13 UTC ya make is running...
🟡 2025-12-06 16:28:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39899 36974 0 2 2902 21

2025-12-06 16:29:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-12-06 16:41:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
44 (only retried tests) 27 0 1 0 16

2025-12-06 16:41:35 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-12-06 16:50:46 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32 (only retried tests) 20 0 0 0 12

🟢 2025-12-06 16:50:52 UTC Build successful.
🟢 2025-12-06 16:51:12 UTC ydbd size 2.3 GiB changed* by -37.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 25029c1 merge: 632c457 diff diff %
ydbd size 2 466 169 640 Bytes 2 466 131 448 Bytes -37.3 KiB -0.002%
ydbd stripped size 524 846 208 Bytes 524 837 696 Bytes -8.3 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

2025-12-06 14:49:06 UTC Pre-commit check linux-x86_64-release-asan for 632c457 has started.
2025-12-06 14:49:23 UTC Artifacts will be uploaded here
2025-12-06 14:51:27 UTC ya make is running...
🟡 2025-12-06 16:00:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12170 12097 0 56 7 10

🟢 2025-12-06 16:00:25 UTC Build successful.
🟢 2025-12-06 16:00:48 UTC ydbd size 3.8 GiB changed* by -50.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 25029c1 merge: 632c457 diff diff %
ydbd size 4 127 824 880 Bytes 4 127 773 376 Bytes -50.3 KiB -0.001%
ydbd stripped size 1 532 696 344 Bytes 1 532 679 576 Bytes -16.4 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru force-pushed the blob_depot/separate-delete-queue branch from b9e1b29 to b2ca408 Compare December 6, 2025 21:38
@github-actions
Copy link

github-actions bot commented Dec 6, 2025

2025-12-06 21:42:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8c2d43a has started.
2025-12-06 21:42:43 UTC Artifacts will be uploaded here
2025-12-06 21:44:56 UTC ya make is running...
🟡 2025-12-06 23:43:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39903 36963 0 8 2905 27

2025-12-06 23:43:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-12-06 23:55:27 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 46 0 0 0 14

🟢 2025-12-06 23:55:34 UTC Build successful.
🟢 2025-12-06 23:55:55 UTC ydbd size 2.3 GiB changed* by -37.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 34c1681 merge: 8c2d43a diff diff %
ydbd size 2 466 169 640 Bytes 2 466 131 592 Bytes -37.2 KiB -0.002%
ydbd stripped size 524 846 208 Bytes 524 837 760 Bytes -8.2 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

2025-12-06 21:42:32 UTC Pre-commit check linux-x86_64-release-asan for 8c2d43a has started.
2025-12-06 21:42:48 UTC Artifacts will be uploaded here
2025-12-06 21:44:59 UTC ya make is running...
🟡 2025-12-06 22:52:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12170 12090 0 66 7 7

🟢 2025-12-06 22:52:18 UTC Build successful.
🟢 2025-12-06 22:52:47 UTC ydbd size 3.8 GiB changed* by -49.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 34c1681 merge: 8c2d43a diff diff %
ydbd size 4 127 824 864 Bytes 4 127 773 824 Bytes -49.8 KiB -0.001%
ydbd stripped size 1 532 696 344 Bytes 1 532 679 768 Bytes -16.2 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) December 7, 2025 09:12
Copy link
Collaborator

@mregrock mregrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexvru alexvru merged commit 9e8876b into ydb-platform:main Dec 7, 2025
9 checks passed
@ydbot
Copy link
Collaborator

ydbot commented Dec 7, 2025

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-25-2, stable-25-2-1, stable-25-3, stable-25-3-1 ▶  Backport
stable-25-3, stable-25-3-1 ▶  Backport
stable-25-3 ▶  Backport

▶  Backport manual

@alexvru alexvru deleted the blob_depot/separate-delete-queue branch December 7, 2025 09:28
@ydbot
Copy link
Collaborator

ydbot commented Dec 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants