-
Notifications
You must be signed in to change notification settings - Fork 0
Phase 2.7.1 Workflow Event Triggers #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements Phase 2.7.1 Workflow Event Triggers, adding automated notification systems for key workflow events across applications, leases, and maintenance. The implementation includes notification services for lease renewals, maintenance status, document expirations, and daily/weekly digest emails.
Changes:
- Added workflow event notification triggers to
ApplicationWorkflowServiceandLeaseWorkflowService - Implemented specialized notification services (
DigestService,LeaseNotificationService,MaintenanceNotificationService,DocumentNotificationService) - Updated
ScheduledTaskServiceto integrate new notification workflows - Standardized lifecycle method calls across Blazor components
- Reorganized route patterns for consistency
Reviewed changes
Copilot reviewed 135 out of 137 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| 2-Aquiis.Application/Services/Workflows/ApplicationWorkflowService.cs | Added notifications for all application workflow state transitions |
| 2-Aquiis.Application/Services/Workflows/LeaseWorkflowService.cs | Added notifications for lease lifecycle events and expiration tracking |
| 2-Aquiis.Application/Services/NotificationService.cs | Added NotifyAllUsersAsync and SendEmailDirectAsync methods |
| 2-Aquiis.Application/Services/DigestService.cs | New service for daily/weekly digest email generation |
| 2-Aquiis.Application/Services/LeaseNotificationService.cs | New service for lease renewal reminder notifications |
| 2-Aquiis.Application/Services/MaintenanceNotificationService.cs | New service for weekly maintenance status summaries |
| 2-Aquiis.Application/Services/DocumentNotificationService.cs | New service for document expiration checks |
| 2-Aquiis.Application/Services/ScheduledTaskService.cs | Integrated new notification services and added weekly task scheduling |
| 2-Aquiis.Application/DependencyInjection.cs | Registered new notification services |
| 5-Aquiis.Professional/Shared/Components/Account/* | Standardized OnInitializedAsync lifecycle method usage |
| 5-Aquiis.Professional/Features/PropertyManagement/* | Updated route patterns for consistency |
| 6-Tests/Aquiis.Application.Tests/* | Updated test setup to include NotificationService dependencies |
Comments suppressed due to low confidence (6)
5-Aquiis.Professional/Shared/Components/Account/Pages/ResetPassword.razor:1
- Duplicate call to
base.OnInitialized()at lines 57 and 67. Remove one of these calls as calling the base method twice can cause unintended side effects.
4-Aquiis.SimpleStart/Shared/Components/Account/Pages/ResetPassword.razor:1 - Duplicate call to
base.OnInitialized()at lines 57 and 67. Remove one of these calls as calling the base method twice can cause unintended side effects.
5-Aquiis.Professional/Shared/Components/Account/Pages/Register.razor:1 Inputinitialization should occur before the call toawait base.OnInitializedAsync()at line 108 to ensure the input model is available for base class initialization logic.
6-Tests/Aquiis.Application.Tests/Services/LeaseWorkflowService.Tests.cs:1- Remove commented-out code. The old constructor call is obsolete since the service now requires
NotificationService.
5-Aquiis.Professional/Extensions/WebServiceExtensions.cs:1 - Documentation incorrectly references 'SimpleStart' instead of 'Professional'. Update to match the actual project.
5-Aquiis.Professional/Extensions/ElectronServiceExtensions.cs:1 - Documentation incorrectly references 'SimpleStart' instead of 'Professional'. Update to match the actual project.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ApplicationConstants.EntityTypes.Lease); | ||
|
|
||
| // TODO: Send email to tenant with welcome info | ||
| // _notificatoinService.SendLeaseActivationEmailToTenant(lease); |
Copilot
AI
Jan 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of '_notificatoinService' to '_notificationService'.
| // _notificatoinService.SendLeaseActivationEmailToTenant(lease); | |
| // _notificationService.SendLeaseActivationEmailToTenant(lease); |
Phase 2.7.1 Workflow Event Triggers are complete.