Skip to content

Conversation

@samuelscheit
Copy link

No description provided.

@xnacly
Copy link
Owner

xnacly commented Jan 17, 2025

Could you provide any reasoning for this contribution and an integration into the existing testing / benchmarking code? I would also appreciate this contribution being in either go or python, go if included in the standard testing code and python if its a change to the benchmarking pipeline in /test.

@samuelscheit
Copy link
Author

  • Performance Testing: Deeply nested JSON objects are challenging for many parsers due to stack limitations or inefficient recursion handling. These tests ensure the JSON parser's ability to process extremely deep structures without stack overflow or memory inefficiencies.
    => Benefit: The performance insights gained can help identify bottlenecks or limitations in the parser.

  • Standard compliance: This test ensures that libjson adheres to JSON standards when handling deep nesting, including maintaining structural integrity and parsing correctly to an equivalent in-memory representation.

@xnacly xnacly self-requested a review January 17, 2025 19:11
@xnacly xnacly added the enhancement New feature or request label Jan 17, 2025
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove this please

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge this file with test/gen.py and add hyperfine calls for each of the depths, as seen in test/bench.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants