make GetSecondNewestMinute total using LEFT JOIN #1471
Draft
+12
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetSecondNewestMinute query could return zero rows when no
“second newest” minute exists (e.g. fewer than two distinct minutes).
With a :one sqlc binding, this surfaced as
sql: no rows in result set.Rewrite the query to LEFT JOIN from a guaranteed single-row anchor,
ensuring the aggregate always has an input row. Missing data now
correctly yields (0, 0) via COALESCE instead of ErrNoRows.
This makes the query total and aligns its behavior with callers that
expect a result even when insufficient history exists.