proptest d14n-ordered stream

[insipx]

Add proptest regression for ordered stream and expose crate::protocol::test during tests to validate stream ordering d14n

Add a regression seed file for the ordered stream property test and introduce a test-only re-export crate::protocol::test. Implement a proptest orders_stream_and_ices_missing in xmtp_api_d14n/src/queries/stream/ordered.rs that verifies topic clock dominance and asserts non-empty icebox when dependencies are missing.

📍Where to Start

Start with the orders_stream_and_ices_missing property test in xmtp_api_d14n/src/queries/stream/ordered.rs.

---

Macroscope summarized 0c8cf67.

[insipx]

This PR is part of a stack of 12 bookmarks:

1. trunk()
2. insipx/causal-fix
3. insipx/icebox-global-cursor
4. insipx/batch-queries
5. insipx/extractors
6. insipx/cursor-store-icebox
7. insipx/icebox-in-ordering
8. insipx/test-ordering
9. insipx/paged-stream
10. insipx/ordered-stream
11. insipx/ordered-stream-test ← this PR
12. push-pnvnmqsyqqqy
13. push-syomxrnuqsnk

---

Created with jj-stack

[claude]

Claude finished @insipx's task —— View job

---

Code Review Complete

Review Date: December 15, 2025 21:25 UTC

Summary

This PR adds comprehensive property-based testing for the OrderedStream implementation. The proptest validates that the stream correctly orders envelopes and ices those with unsatisfied dependencies. Overall, the test is well-structured and follows proptest best practices.

✅ Strengths

1. Excellent test strategy: Using missing_dependencies() to generate both sorted envelopes and randomly removed dependencies is a robust approach for testing offline ordering edge cases.

2. Proper assertions: The test validates two critical properties:

   • All returned envelopes have their dependencies satisfied (lines 136-144)
   • Envelopes with missing dependencies are properly iced (lines 147-154)

3. Good use of #[xmtp_common::test]: Follows the project's testing guidelines for cross-platform compatibility.

4. Regression file committed: The proptest regression file ensures failed cases are re-run, preventing regressions.

💡 Minor Suggestions

1. Test coverage gap (xmtp_api_d14n/src/queries/stream/ordered.rs:116-156): The current test only checks a single stream chunk. Consider adding a test case for multi-chunk streams to verify that the TopicCursor is correctly maintained across multiple poll_next() calls and that iced items from earlier chunks can be resolved by later chunks.

2. Documentation clarity (xmtp_api_d14n/src/queries/stream/ordered.rs:146-154): The conditional assertion logic could benefit from a comment explaining why has_deps_on_removed is necessary—specifically that not all removed envelopes will cause icing (only those that have dependent envelopes in the stream).

3. Export visibility (xmtp_api_d14n/src/protocol/mod.rs:29): The pub use utils::test; export makes test utilities public. Verify this is intentional for external testing—if only for internal use, consider pub(crate).

🔒 Security & Performance

• No security concerns identified
• Performance is appropriate for property-based testing; the test uses .now_or_never() correctly for single-chunk validation

---