50: package update fileuploader #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
d9m0n4
reviewed
Nov 23, 2025
| return 'Файл слишком большой'; | ||
| } | ||
|
|
||
| return undefined; |
Contributor
There was a problem hiding this comment.
это наверное вообще не нужно, если не выполнится ни одно условие то итак будет undefined
d9m0n4
reviewed
Nov 23, 2025
| }); | ||
| } | ||
|
|
||
| return; |
Contributor
There was a problem hiding this comment.
эта функция по идее void по этому тут не нужен return в конце
| /> | ||
| <FileUploader | ||
| onChange={handleInput} | ||
| // @ts-expect-error - onError пересекается с пропсом DefaultInputPropsT |
Contributor
There was a problem hiding this comment.
Это нужно поправить на уровне компонента, иначе он сломан останется. Нужен PR в xi.kit
|
|
||
| const validateBeforeUpload = (files: File[]): string | undefined => { | ||
| const file = files[0]; | ||
| const allowedTypes = ['image/png', 'image/jpeg', 'image/jpg']; |
Contributor
There was a problem hiding this comment.
Как будто нам нужно расширить поддерживаемые типы. Как минимум, я знаю, что есть ещё webp, который будет работать. Я бы здесь поисследовал и потестировал данное поведение
| const file = files[0]; | ||
| const allowedTypes = ['image/png', 'image/jpeg', 'image/jpg']; | ||
| if (!allowedTypes.includes(file.type)) { | ||
| return 'Поддерживаются только файлы PNG и JPEG'; |
Contributor
There was a problem hiding this comment.
Подсказка должна совпадать с allowedTypes
| return; | ||
| } | ||
|
|
||
| if (file.size > 5 * 1024 * 1024) { |
Contributor
There was a problem hiding this comment.
Думаю, что это 5 Мб
unknownproperty
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.