This repository was archived by the owner on Apr 24, 2025. It is now read-only.
46955357: Board draw tool, elements transformer #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
unknownproperty
left a comment
unknownproperty
left a comment
There was a problem hiding this comment.
Всё выглядит хорошо, мне нравится, то как ты разделяешь код. Я оставил один комментарий, скорее придирка, но всё же попробовать стоит. Также я очень сильно прошу тебя начать писать комментарии к коду, особенно, где сложная логика, ибо человек со стороны уже может легко в этом запутаться
| }; | ||
| if (transformerRef.current && selectedElementId) { | ||
| const selectedNode = layerRef.current?.findOne(`#${selectedElementId}`); | ||
| if (selectedNode) { |
Contributor
There was a problem hiding this comment.
Мне чуть-чуть не нравится вложенность аж целых 4 if, может как-нибудь переделаем?
unknownproperty
approved these changes
Mar 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.