-
Notifications
You must be signed in to change notification settings - Fork 10
chore: enable session history for openai agent. #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Klaus Ma <klausm@nvidia.com>
Summary of ChangesHello @k82cn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the OpenAI agent example by introducing robust session history management. It refactors the context object to store conversational messages and modifies the custom session implementation to load and persist this history. This change allows the agent to maintain conversational state across multiple interactions, leading to more coherent and context-aware responses without requiring manual history passing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enables session history for the OpenAI agent example. The changes involve introducing a MyContext data class to hold session messages, updating MyCustomSession to initialize from and persist to this context, and modifying the agent logic to use this sessioning mechanism. The changes are well-structured and align with the goal. I've pointed out a potential crash due to unhandled JSON decoding errors when loading session history, which should be addressed.
| for message in ctx.messages: | ||
| self._messages.append(json.loads(message)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The json.loads(message) call could raise a json.JSONDecodeError if a message from the context is not a valid JSON string. This would cause the agent to fail during the initialization of the session. It's safer to handle this potential error, for example by logging a warning and skipping the malformed message.
| for message in ctx.messages: | |
| self._messages.append(json.loads(message)) | |
| for message in ctx.messages: | |
| try: | |
| self._messages.append(json.loads(message)) | |
| except json.JSONDecodeError: | |
| logger.warning("Failed to decode message from session history: %s", message) |
No description provided.