Modified the VdiAndSrOps test so it actually does something for VDIs. #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@cloud.com>
xueqingz
reviewed
Dec 31, 2025
| } | ||
| } | ||
| } | ||
| return null; |
Contributor
There was a problem hiding this comment.
If return null, the var vdiRec = newVdiRecord(sr); will raise error.
xueqingz
reviewed
Dec 31, 2025
| break; | ||
| case "VDI.snapshot": | ||
| dummy.snapshot(c, driverParams); | ||
| vdi = VDI.getByNameLabel(c, TEST_VDI_NAME).iterator().next(); |
Contributor
There was a problem hiding this comment.
There may have an issue when VDI.getByNameLabel return [] ?
xueqingz
reviewed
Dec 31, 2025
| return vdiRec; | ||
| } | ||
|
|
||
| private SR findSrForVdi(Connection c) throws IOException { |
Contributor
There was a problem hiding this comment.
what about
private SR findSrForVdi(Connection c) throws Exception {
...
for(){ ... }
throw new Exception("No suitable SR found for VDI creation");
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.