Skip to content

Conversation

@bernhardkaindl
Copy link
Contributor

@bernhardkaindl bernhardkaindl commented Nov 15, 2024

Topic: Fix GitHub CI

  • GitHub dropped support for EOL Python versions in GitHub CI

Contents:

  • It has become impractical to use EOL versions like Python 2.7 & 3.6 in CI
  • It has become counterproductive (hurts pyright) to use pyre CI, disable it for now.
  • Move forward to run the unit tests with Python 3.11

A follow-up PR has been created that includes this commit and compensates for the minimal loss in code coverage:

Note:
If you have review comments, I'd like to apply them using the last PR in this series!

- It has become impractical to use EOL versions like Python 3.6 in CI
- It has become counterproductive to use pyre CI, disable it for now.
- Move forward to run the unit tests with Python 3.11

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@bernhardkaindl bernhardkaindl force-pushed the fix-github-ci-py38-removed branch from 2709be2 to 16ed521 Compare November 15, 2024 13:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11857456745

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.5%) to 83.184%

Files with Coverage Reduction New Missed Lines %
xcp/accessor.py 1 89.1%
xcp/pci.py 2 85.39%
xcp/xmlunwrap.py 2 92.31%
xcp/cpiofile.py 3 75.26%
xcp/compat.py 6 78.57%
Totals Coverage Status
Change from base Build 9109272969: -0.5%
Covered Lines: 2790
Relevant Lines: 3354

💛 - Coveralls

@bernhardkaindl bernhardkaindl merged commit df61175 into master Nov 20, 2024
13 checks passed
@bernhardkaindl bernhardkaindl deleted the fix-github-ci-py38-removed branch September 26, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants