CP-54461: SWRAID Upgrade & Restore #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rosslagerwall
left a comment
rosslagerwall
left a comment
There was a problem hiding this comment.
I've reviewed the top commit only since the others were reviewed in #248.
GeraldEV
force-pushed
the
private/geralde/CP-54461
branch
from
29bd393 to
d4d1333
Compare
XS8 only supports UEFI installations Since CH8.2 is out of support, upgrades will only be possible from UEFI installations and therefore restore can only be between UEFI installations. EFI/ESP partition mounting is now always necessary. Signed-off-by: Gerald Elder-Vass <gerald.elder-vass@cloud.com>
Gracefully handle failures to probe disks e.g. when the partitions are not populated. Get the physical devices for the SWRAID installation when performing an upgrade. Signed-off-by: Gerald Elder-Vass <gerald.elder-vass@cloud.com>
Signed-off-by: Gerald Elder-Vass <gerald.elder-vass@cloud.com>
Signed-off-by: Gerald Elder-Vass <gerald.elder-vass@cloud.com>
GeraldEV
force-pushed
the
private/geralde/CP-54461
branch
from
d4d1333 to
6b56afa
Compare
rosslagerwall
approved these changes
Jul 1, 2025
| if len(physical_disks) == 0: | ||
| raise RuntimeError("Failed to identify physical devices of SWRAID device: %s" % disk_device) | ||
|
|
||
| assembleCommand = ["mdadm", "--assemble", "--run", disk_device, physical_disks[0]] |
Contributor
There was a problem hiding this comment.
I think you could simplify this to:
assembleCommand = ["mdadm", "--assemble", "--run", disk_device, *physical_disks]
Contributor
Author
There was a problem hiding this comment.
This could create minor issues if there are more than two disks present, but then that should be checked for too? I think we'll leave this as is for now :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on PR #248