Add Python code checks using pytype, mypy, pyright and pylint #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @freddy77!
As written before, this PR only adds new files for code checks, so it should not cause conflicts.
I successfully tested
mypyandpyrightin GitHub CI!Here is a sample (private) PR that shows an intentional CI failure that generated an automated code review comment for the intentionally added broken code:
xenserver-next#1
xenserver-next#1 (comment)
Besides the comments from
mypyandpyright(Microsoft's code checker) that I tested on this PR,I also integrated the
pylintandpytypecheckers.All checkers also work locally with minimal effort by using
pre-commit.It is a battle-hardened CI solution that installs Python environments for
each CI check and runs the checks in their respective environment.
Howto:
sudo apt install pipx;pipx install pre-commitpip install pre-commit(if your system allows it)pre-commit run -avpre-commit run.