quicktest: start running quicktest_vm_lifecycle again #6815
+86
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quicktest was listing potentially thousands of VDIs and querying its properties, just to find out whether the resulting list was empty or not. We don't need to produce the full list to check whether it is empty or not: we can stop once we have the 1st element. Replace the List with a Seq. Before: ``` time ./quicktest.exe -run-only Quicktest_vm_lifecycle [...] real 0m13.957 ``` After: ``` real 0m12.584s ``` Signed-off-by: Edwin Török <edwin.torok@citrix.com>
Some (read-only) SRs can contain a large number of VDIs, but these cannot "leak" VDIs if we cannot create or destroy them. Before: ``` real 0m12.584s ``` After: ``` real 0m7.853s ``` Signed-off-by: Edwin Török <edwin.torok@citrix.com>
Before: ``` real 0m7.853s ``` After: ``` real 0m7.746s ``` Signed-off-by: Edwin Török <edwin.torok@citrix.com>
Before: ``` real 0m7.746s ``` After: ``` real 0m6.095s ``` Signed-off-by: Edwin Török <edwin.torok@citrix.com>
The difference is not really measurable. But I found out there is another pre-existing flag that can speed it up, `-default-sr`. Then the leak checks are only done on that SR, and not all the SRs. So the best way is to run this (at least during development): ``` time ./quicktest.exe -run-only Quicktest_vm_lifecycle -skip-stress -default-sr [...] real 0m1.709s ``` Signed-off-by: Edwin Török <edwin.torok@citrix.com>
Signed-off-by: Edwin Török <edwin.torok@citrix.com>
Signed-off-by: Edwin Török <edwin.torok@citrix.com>
andyhhp
reviewed
Jan 5, 2026
Comment on lines
368
to
370
| | None -> | ||
| Printf.eprintf "Template not found: %S\n" template_name; | ||
| Printf.eprintf "Template not found: %S\n" template_name ; | ||
| [] |
Collaborator
There was a problem hiding this comment.
Minor nit, but this hunk is in the wrong change. It should be in the previous commit.
lindig
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intended to write some new VM tests, and the existing VM lifecycle tests looked like a good starting point.
But it turns out that we stopped running this test completely when we dropped the
CoreOStemplate.Use a memtest ISO instead of the CoreOS template.
Also optimize various startup and shutdown code in quicktest, because even a no-op test that did nothing took 14s to run.
Draft PR, because it needs more testing, and I'm not entirely happy with how the SR filtering works, e.g. this test still won't run if
-default-sris passed (and passing-default-sris very useful during development because it further cuts down startup time by 5s).I should then be able to reuse this code in the new tests that I'm writing.