Provisional Feature/netcore integration #436
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metry into feature/netcore
…metry into feature/netcore
…metry into feature/netcore
…el precision not minumum gap
Fixed self intersecting profile wires Fixed some precision issues in Composite curves Fixed Polygonal Bounded Half Space issues Removed duplicate calls to BuildExtrudedAreaSolids Added test cases for above
…then engaged in a boolean
…metry into feature/netcore
Replace std::mutex by std::shared_mutex
I.e. only when analyzer notifies a valid shape.
Fixed calling the simplification of the resulting shape of Boolean operation in NBooleanFactory only when safe (after analyzing).
Fixed building composite curve 2d segments for raw conics and trimmed/offset conics
…ceptions during concurrent IfcGradientCurve processing
…ve-build-race Fix race condition in BuildCurve causing false "previously failed" exceptions during concurrent IfcGradientCurve processing
Fixed Swept Disk Solids parameterization semantics
Updated minot 3rd party & test deps Tweaked referencing of Tessellator by netFramework project
…eometry.Abstractions into feature/netcore8
Added Readmes to packages.
Added netcore8 support Integrate Abstractions into sln (including history)
Partly due to breaking changes partly due to migration of Abstractions Added abstractions to GE meta package
Workaround is now incorporated into latest VS17.12.2 as per https://developercommunity.visualstudio.com/t/VS-17130-preview-1-CLexe-crash-CC/10796431?q=ice&sort=newest Fuller details at https://devblogs.microsoft.com/cppblog/fixing-overload-resolution-for-parameter-arrays-in-c-cli/
…te/indexed curves The core issue was incorrect handling of curve parameterization when processing IfcSweptDiskSolid directrix curves, particularly composite curves with mixed segment types (polylines, trimmed circles, etc.) and indexed poly curves with line and arc segments. - Start/End parameters for IfcSweptDiskSolid must align with the parameterization space of the underlying directrix curve - For IfcCompositeCurve, each segment has its own parameterization: * Polylines: [0, 1] per segment * Trimmed curves with circles: trimmed arc radial length (e.g., [0, 360] or [270, 360]) - For IfcIndexedPolyCurve, each segment has its own parameterization: * IfcLineIndex: [0, 1] per segment * IfcArcIndex: arc radial length (e.g., [0, 360] or [270, 360]) - Previous implementation didn't correctly accumulate and map these parameters across composite/indexed curve segments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.