Issue-1201 : Notify slack for the new issue/bounties #1338

devmaster-x · 2026-01-12T04:03:47Z

Related Issues

close #1201

What is updated

Notify about new issues/bounties to the slack channel using webhook.

Screentshot

Test

…resolve signup page issue

alexanmtz

It's doing great @devmaster-x 👌

Tested posting to the channel, and it's working well 🙏

Just need some small adjustment for the case of the issue imported is set to not_listed

I would recommend to add to the tasks tests a spy which checks if the Slack method is called, and it's not called in case for tasks with not_listed set.

alexanmtz · 2026-01-13T21:39:34Z

src/modules/tasks/taskBuilds.js

+            if (userData.receiveNotifications) {
+              TaskMail.new(userData, taskData)
            }
+            issueAddedComment(task)


We should check here before calling issueAddedComment whether the issue is not_listed or private; in that case, it shouldn't be added to the channel.

@alexanmtz

Updated code to check not_listed and private issues before calling issueAddedComment().

const isTaskPublic = !(taskData.not_listed === true || taskData.private === true) if (isTaskPublic) { issueAddedComment(task) notifyNewIssue(taskData, userData) }

alexanmtz · 2026-01-13T21:41:10Z

src/modules/orders/orderBuilds.js

  const percentage = orderCreated.Plan?.feePercentage

+  // Notify Slack about new bounty
+  if (orderCreated.Task && orderCreated.User) {


Don't post on the channel if the related task is set to not_listed or private

@alexanmtz

Updated code to check not_listed and private issues before notify about new bounty.

const shouldNotifySlack = orderCreated.Task && orderCreated.User && !( orderCreated.Task.dataValues.not_listed === true || orderCreated.Task.dataValues.private === true ) if (shouldNotifySlack) { notifyNewBounty( orderCreated.Task.dataValues, orderCreated.dataValues, orderCreated.User.dataValues ) }

alexanmtz

Hey @devmaster-x, some more improvements are needed to have everything in place to merge.

alexanmtz · 2026-01-15T13:00:51Z

src/modules/orders/orderUpdateAfterStripe.js

+      .then(async (updatedOrder) => {
        if (orderParameters.plan === 'full') {
          PaymentMail.support(user, task, order)
        }
        PaymentMail.success(user, task, order.amount)
+
+        // Send Slack notification for new bounty payment
+        if (orderPayload.paid && orderPayload.status === 'succeeded') {
+          const orderData = {
+            amount: order.amount || orderParameters.amount,
+            currency: order.currency || orderParameters.currency || 'USD'
+          }
+          notifyNewBounty(task.dataValues, orderData, user).catch((e) => {
+            console.log('error on send slack notification for new bounty', e)
+          })
+        }
+


@devmaster-x because you introduced async it should be something like this?

Suggested change

.then(async (updatedOrder) => {

if (orderParameters.plan === 'full') {

PaymentMail.support(user, task, order)

}

PaymentMail.success(user, task, order.amount)

// Send Slack notification for new bounty payment

if (orderPayload.paid && orderPayload.status === 'succeeded') {

const orderData = {

amount: order.amount || orderParameters.amount,

currency: order.currency || orderParameters.currency || 'USD'

}

notifyNewBounty(task.dataValues, orderData, user).catch((e) => {

console.log('error on send slack notification for new bounty', e)

})

}

.then(async (updatedOrder) => {

if (orderParameters.plan === 'full') {

PaymentMail.support(user, task, order)

}

PaymentMail.success(user, task, order.amount)

// Send Slack notification for new bounty payment

if (orderPayload.paid && orderPayload.status === 'succeeded') {

const orderData = {

amount: order.amount || orderParameters.amount,

currency: order.currency || orderParameters.currency || 'USD'

}

try {

await notifyNewBounty(task.dataValues, orderData, user)

} catch (e) {

console.log('error on send slack notification for new bounty', e)

}

}

alexanmtz · 2026-01-15T13:14:04Z

test/task.test.js

+    it('should not call Slack methods when task is created with not_listed set to true', async () => {
+      chai.use(spies)
+      const slackModule = require('../src/modules/slack')
+      const slackSpy = chai.spy.on(slackModule, 'notifyNewIssue')
+      const originalBotModule = require('../src/modules/bot/issueAddedComment')
+      const botSpy = chai.spy(originalBotModule)
+
+      try {
+        const user = await registerAndLogin(agent)
+        const task = await models.Task.create({
+          url: 'https://github.com/worknenjoy/gitpay/issues/999',
+          provider: 'github',
+          userId: user.body.id,
+          title: 'Test Task',
+          not_listed: true
+        })
+
+        const userData = await task.getUser()
+        const taskData = task.dataValues
+
+        // Test the actual logic from taskBuilds.js
+        const isTaskPublic = !(taskData.not_listed === true || taskData.private === true)
+        if (isTaskPublic) {
+          botSpy(task)
+          slackModule.notifyNewIssue(taskData, userData)
+        }
+
+        expect(slackSpy).to.not.have.been.called()
+        expect(botSpy).to.not.have.been.called()
+      } finally {
+        chai.spy.restore(slackModule, 'notifyNewIssue')
+      }
+    })
+
+    it('should not call Slack methods when task is created with private set to true', async () => {
+      chai.use(spies)
+      const slackModule = require('../src/modules/slack')
+      const slackSpy = chai.spy.on(slackModule, 'notifyNewIssue')
+      const originalBotModule = require('../src/modules/bot/issueAddedComment')
+      const botSpy = chai.spy(originalBotModule)
+
+      try {
+        const user = await registerAndLogin(agent)
+        const task = await models.Task.create({
+          url: 'https://github.com/worknenjoy/gitpay/issues/998',
+          provider: 'github',
+          userId: user.body.id,
+          title: 'Test Task',
+          private: true
+        })
+
+        const userData = await task.getUser()
+        const taskData = task.dataValues
+
+        // Test the actual logic from taskBuilds.js
+        const isTaskPublic = !(taskData.not_listed === true || taskData.private === true)
+        if (isTaskPublic) {
+          botSpy(task)
+          slackModule.notifyNewIssue(taskData, userData)
+        }
+
+        expect(slackSpy).to.not.have.been.called()
+        expect(botSpy).to.not.have.been.called()
+      } finally {
+        chai.spy.restore(slackModule, 'notifyNewIssue')
+      }
+    })
+
+    it('should call Slack methods when task is created as public', async () => {
+      chai.use(spies)
+
+      // Set up spies first
+      const slackModule = require('../src/modules/slack')
+      const slackSpy = chai.spy.on(slackModule, 'notifyNewIssue')
+
+      // For default export function, create a spy wrapper
+      delete require.cache[require.resolve('../src/modules/bot/issueAddedComment')]
+      const originalBotModule = require('../src/modules/bot/issueAddedComment')
+      const botSpy = chai.spy(originalBotModule)
+
+      try {
+        const user = await registerAndLogin(agent)
+        // Create task without explicitly setting not_listed/private (should default to false)
+        const task = await models.Task.create({
+          url: 'https://github.com/worknenjoy/gitpay/issues/997',
+          provider: 'github',
+          userId: user.body.id,
+          title: 'Test Task'
+        })
+
+        const userData = await task.getUser()
+        const taskData = task.dataValues
+
+        // Test the actual logic from taskBuilds.js
+        const isTaskPublic = !(taskData.not_listed === true || taskData.private === true)
+        if (isTaskPublic) {
+          // Use the spied version
+          botSpy(task)
+          slackModule.notifyNewIssue(taskData, userData)
+        }
+
+        expect(slackSpy).to.have.been.called()
+        expect(botSpy).to.have.been.called()
+      } finally {
+        chai.spy.restore(slackModule, 'notifyNewIssue')
+        // Restore cache
+        delete require.cache[require.resolve('../src/modules/slack')]
+        delete require.cache[require.resolve('../src/modules/bot/issueAddedComment')]
+      }
+    })
+


I guess here is not the right approach to test the integration. This should be more like an API testing, check other tests in the file, like calling the agent to the endpoint to create a new task and check if the Slack is called, and instead of these spies, there's a good example of an approach using Stubs on userAuth.test:242, so you can check if your integration is called and the expected params

devmaster-x added 4 commits January 8, 2026 19:03

Chore : add cross-env to npm commands, error handling on db connect, …

1ca04de

…resolve signup page issue

implement slack notification feature

1de29dd

Fix lint and update slack notication message content

47c7caf

fix lint

cfc2cbe

dosubot bot added the slack trigger to slack channel label Jan 12, 2026

devmaster-x added 2 commits January 12, 2026 13:05

Update slack notification test

cba69fb

Fix build error

5b33e15

alexanmtz requested changes Jan 13, 2026

View reviewed changes

devmaster-x added 2 commits January 14, 2026 22:55

update handling for not_listed, private issues in slack notification

e1147f7

fix build CI errors

4b1448e

devmaster-x force-pushed the feat/post-slack-notifications branch from e1d86a3 to 4b1448e Compare January 14, 2026 16:21

devmaster-x requested a review from alexanmtz January 14, 2026 16:45

alexanmtz requested changes Jan 15, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Issue-1201 : Notify slack for the new issue/bounties #1338

Issue-1201 : Notify slack for the new issue/bounties #1338

devmaster-x commented Jan 12, 2026 •

edited

Loading

Uh oh!

alexanmtz left a comment

Uh oh!

alexanmtz Jan 13, 2026 •

edited

Loading

Uh oh!

devmaster-x Jan 14, 2026

Uh oh!

alexanmtz Jan 13, 2026 •

edited

Loading

Uh oh!

devmaster-x Jan 14, 2026

Uh oh!

alexanmtz left a comment

Uh oh!

alexanmtz Jan 15, 2026

Uh oh!

alexanmtz Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Issue-1201 : Notify slack for the new issue/bounties #1338

Are you sure you want to change the base?

Issue-1201 : Notify slack for the new issue/bounties #1338

Conversation

devmaster-x commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues

What is updated

Screentshot

Test

Uh oh!

alexanmtz left a comment

Choose a reason for hiding this comment

Uh oh!

alexanmtz Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devmaster-x Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

alexanmtz Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devmaster-x Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

alexanmtz left a comment

Choose a reason for hiding this comment

Uh oh!

alexanmtz Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

alexanmtz Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

devmaster-x commented Jan 12, 2026 •

edited

Loading

alexanmtz Jan 13, 2026 •

edited

Loading

alexanmtz Jan 13, 2026 •

edited

Loading