Skip to content

Conversation

@akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Jan 6, 2026

https://wearezeta.atlassian.net/browse/WPB-5297

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 6, 2026
@akshaymankar akshaymankar force-pushed the flake branch 2 times, most recently from 97e5df1 to 070b5c8 Compare January 7, 2026 08:18
@akshaymankar akshaymankar changed the title Use nix flakes instead of niv Use nix flakes instead of niv and manually pinned git dependencies Jan 7, 2026
@akshaymankar akshaymankar marked this pull request as ready for review January 7, 2026 10:24
@akshaymankar akshaymankar requested review from a team as code owners January 7, 2026 10:24
flake.nix Outdated
flake-utils.url = "github:numtide/flake-utils";

cryptobox-haskell = {
url = "github:wireapp/cryptobox-haskell?rev=7546a1a25635ef65183e3d44c1052285e8401608";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think commit hash should only be at flake.lock level to be able to rely on `nix flake update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I think we don't want all of these to automatically update. But this one we might want.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually nearly all of them have branches we can follow. Only amazonka is a bit difficult.

Copy link
Contributor

@blackheaven blackheaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@akshaymankar akshaymankar force-pushed the flake branch 3 times, most recently from db8279d to b44764f Compare January 7, 2026 15:47
the images.all derivation builds a nice link farm which can be used instead.
@akshaymankar akshaymankar merged commit 882e66f into develop Jan 8, 2026
12 checks passed
@akshaymankar akshaymankar deleted the flake branch January 8, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants