-
Notifications
You must be signed in to change notification settings - Fork 334
Use nix flakes instead of niv and manually pinned git dependencies #4933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
97e5df1 to
070b5c8
Compare
flake.nix
Outdated
| flake-utils.url = "github:numtide/flake-utils"; | ||
|
|
||
| cryptobox-haskell = { | ||
| url = "github:wireapp/cryptobox-haskell?rev=7546a1a25635ef65183e3d44c1052285e8401608"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think commit hash should only be at flake.lock level to be able to rely on `nix flake update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I think we don't want all of these to automatically update. But this one we might want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually nearly all of them have branches we can follow. Only amazonka is a bit difficult.
Also use published versions of warp and http2, they already contain the changes that were pinned
blackheaven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
this removes the extraneous 'all' from the list
db8279d to
b44764f
Compare
the images.all derivation builds a nice link farm which can be used instead.
https://wearezeta.atlassian.net/browse/WPB-5297
Checklist
changelog.d