WPB-21366: Add user type field to GET /search/contacts
#4913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
eyeinsky
force-pushed
the
ml/WPB-21366--add-type-field-to-search-contacts
branch
2 times, most recently
from
fbd0b50 to
c76d34c
Compare
eyeinsky
force-pushed
the
ml/WPB-21366--add-type-field-to-search-contacts
branch
5 times, most recently
from
5ec54b8 to
83fcf33
Compare
akshaymankar
force-pushed
the
ml/WPB-21366--add-type-field-to-search-contacts
branch
2 times, most recently
from
f5501ad to
38aa39c
Compare
- fix comment - add `getUserType` helper, use it
It needs to be constructed at sync time: it's a derived field (i.e, not a field on the user table in Cassandra).
make sanitize-pr
fisx
force-pushed
the
ml/WPB-21366--add-type-field-to-search-contacts
branch
from
38aa39c to
ddac5ef
Compare
There is prior art to this with email visibility and role, we're just following the pattern. There might be a nicer way, though.
fisx
force-pushed
the
ml/WPB-21366--add-type-field-to-search-contacts
branch
from
ddac5ef to
c79de27
Compare
fisx
force-pushed
the
ml/WPB-21366--add-type-field-to-search-contacts
branch
from
fbf5490 to
3c4847b
Compare
The code isn't a lot shorter this way, but there aren't two places that make the same debatable decision to lie about user types of bots before ES re-index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPB-21366: [Backend] Add type field to search contacts endpoint response
This PR adds the type field to contacts retrieved from
GET /search/contacts. To achieve this it needs to send that field to Elastic Search as that's where the search happens. The challenge (sometimes) is in how to determine whether the user is an app or not, as that depends on whether there is an according row in the apps table for the user (i.e, it's a derived field and not a field on the user row).Leaving this as draft, as there is still work outstanding:
XXX, all these should be resolved before mergingState [StoredApp]there to theUserStoreinterpreter, as consulting the apps determines a user's typeChecklist
changelog.d