added merge to reserve only midi notes and cc's on the channels defin… #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in settings (or default channel) this frees up the same notes on different channels to be passed to Ableton - this allows controllers to have notes controlling Live functions on reserved channels, while same notes on different channels will be played by the instrument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the way
build_midi_mapexecutes so that it only reserves the notes and cc's on specific channels. As far as I could understand, in the original implementation,build_midi_mapreserved the notes and cc's from the built callbacks on all channels; this made it not possible to send actual notes with a controller to the track, i.e. if I wanted a keyboard controller to use half of the keys set to channel 1 to control Live, while the other half on channel 2 to play notes; this was not possible unless I removed the corresponding notes fromsettings.py.Hope this change makes sense, could also make it variable based :)