-
Notifications
You must be signed in to change notification settings - Fork 61
build: use nox for tests and docs #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@maartenbreddels, @mariobuikhuizen I would like the doc to be build on main (at least latest) but when I install in dev mode there are many npm command that start. Of course it wasn't an issue before because RDT was build from the pipy version. |
|
I never build on rtd, because there wasn’t enough memory. Why do you want to do that? |
|
If I want to work on the API build in #238 I would like to make sure latest is on track with main. So I would need to run: |
|
I think you should install Jupyter lab to be able to build |
|
thanks @maartenbreddels for the tips. The complete solution was "install jupyterlab before the lib to enable the build of jupyter extentions when with the pre-install job, it works like a charm. This is then ready for review |
|
@maartenbreddels things were working just fine when I finished my PR: https://readthedocs.org/projects/ipyvuetify/builds/19602806/ but now I get NPM warnings/errors everywhere: https://readthedocs.org/projects/ipyvuetify/builds/19959839/ Is there something to change there ? like node version ? python version ? |
368ca6d to
e241012
Compare
|
sorry for the noise. I made many tests from RDT side. I hope they will help me find a solution from their side: readthedocs/readthedocs.org#10223 |
0017486 to
f4937c0
Compare
|
This PR now depends on the fix in: #259 |
|
@mariobuikhuizen I rebased on the current master and solved the remaining RDT related issue. I think this one is also ready to go. |
mariobuikhuizen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Thanks!
One small issue:
since widgetti#240, this is completely handled by the build
Fix #239
In this PR I added a few configurations to build unit tests and documentation pages using nox. It creates isolated environments to ensure that the build will work when send to RDT. It's also the first step toward unit testing.
docs/_buildfolder.nox -s docs.gitignoredocset of extra_requires to have everything needed for the documentationAs I need to check the RDT build there will surely be test commits, I assume you will just squash my PR so I'm just sorry for the noise.