Implement actual token cleanup logic #426
Conversation
Replaced the simulation code in `cleanupExpiredTokens` with actual database deletion logic using Drizzle ORM. Updated `@the-new-fuse/database` to export the `authSessions` schema. Injected `DatabaseService` into `CleanupProcessor`. Added `lt` (less than) operator import from `drizzle-orm` to filter expired tokens.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
PR Description Missing Sections
|
whodaniel
left a comment
whodaniel
left a comment
There was a problem hiding this comment.
Token Cleanup Implementation Review
This PR successfully implements actual database cleanup for expired tokens:
✅ Uses Drizzle ORM with proper query builder
✅ Deletes expired tokens from authSessions table
✅ Proper dependency injection of DatabaseService
✅ Exports authSessions schema from database package
✅ Replaces TODO with working implementation
Code Quality:
- Correct use of
lt()operator for date comparison - Proper error handling maintained
- Returns actual count instead of mock data
Recommendation: Approve and merge.
Implemented the
cleanupExpiredTokensmethod inapps/backend/src/jobs/processors/cleanup.processor.tsto delete expired tokens from theauthSessionstable using Drizzle ORM.Also exported
authSessionsfrompackages/database/src/index.tsto make it accessible.Verified that the method uses the correct database service and query logic.
Reverted temporary changes to
package.jsonandpnpm-lock.yamlthat were made during the testing process.PR created automatically by Jules for task 1953273572461393205 started by @whodaniel