Implement actual file system cleanup in backend CleanupProcessor #422
Conversation
- Implements `cleanupTempFiles` using `fs/promises`. - Targets `uploads/temp` and `tmp` directories relative to CWD. - Avoids `os.tmpdir()` to prevent accidental deletion of system files. - Respects `batchSize` and `olderThanDays` parameters. - Handles directory and file access errors gracefully.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
PR Description Missing Sections
|
whodaniel
left a comment
whodaniel
left a comment
There was a problem hiding this comment.
File System Cleanup Implementation Review
This PR implements actual file system cleanup:
✅ Replaces TODO with real fs/promises implementation
✅ Targets specific directories: uploads/temp and tmp
✅ Checks file modification times for age-based deletion
✅ Includes safety checks for directory existence
✅ Handles errors gracefully on per-file basis
✅ Avoids os.tmpdir() to prevent system file deletion
Safety Features:
- Respects
batchSizeandolderThanDaysparameters - Only operates on configured directories
- Error handling prevents batch failure
Recommendation: Approve and merge.
Implemented the file system cleanup logic in
CleanupProcessor.Instead of a TODO and sleep, the processor now iterates through configured temporary directories (
uploads/tempandtmp), checks file modification times, and deletes files older than the specified retention period.It includes safety checks to ensure directories exist and handles errors on a per-file basis.
Verified using a standalone script to confirm deletion behavior.
Note: Pre-existing build failures in
mcp-corewere observed but are unrelated to these changes.PR created automatically by Jules for task 11213588373411896113 started by @whodaniel