Skip to content

Conversation

@faisal
Copy link
Contributor

@faisal faisal commented Dec 12, 2025

Minitest is moving forward. This is the last 5.x version.

Check list:

@faisal faisal marked this pull request as draft December 12, 2025 11:04
@faisal
Copy link
Contributor Author

faisal commented Dec 12, 2025

This is very broken, possibly due to the Minitest update itself.

@faisal faisal force-pushed the bump_minitest branch 2 times, most recently from c98ba96 to 485072a Compare December 12, 2025 12:22
@faisal faisal marked this pull request as ready for review December 24, 2025 09:33
Copy link
Collaborator

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faisal Looks good, thanks! 👍🏻

@faisal
Copy link
Contributor Author

faisal commented Dec 26, 2025

I've now squashed this back to one commit again.

Note: Minitest is now on to 6.0. We can update to that once minitest-around works with it or we stop needing minitest-around.

@faisal
Copy link
Contributor Author

faisal commented Dec 27, 2025

With splattael/minitest-around#40, I hope the next release of minitest-around works with Minitest 6. We're poking at some CI issues on that gem first, though.

@faisal
Copy link
Contributor Author

faisal commented Dec 28, 2025

CI issues resolved. Waiting on an updated release.

- Bump minitest to 5.2.7 (the last compatible with Ruby 3.1.x)
@faisal
Copy link
Contributor Author

faisal commented Dec 28, 2025

Minitest 6.0 requires Ruby 3.2, so I'll update to that as part of the Ruby 3.2 PR.

Assuming the latest test run is green I think this should be ready to merge.

@faisal
Copy link
Contributor Author

faisal commented Dec 28, 2025

@etagwerker Did you want to cut one final release to restore Ruby 3.1 compatibility (branching before the 3.1 EOL commit)? If so, do you want to pick this up in the branch? If the answer isn't yes to both of those, I can close this out.

@faisal faisal closed this Dec 29, 2025
@faisal faisal deleted the bump_minitest branch December 29, 2025 11:09
@etagwerker
Copy link
Collaborator

@faisal Yes, that sounds like a good idea. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants