Skip to content

Conversation

@faisal
Copy link
Contributor

@faisal faisal commented Nov 9, 2025

Rubocop now gives us a warning:

$ be rubocop            
.rubocop.yml:19: `Metrics/MethodLength` is concealed by line 96
Inspecting 116 files
....................................................................................................................

116 files inspected, no offenses detected

This PR does two things:

  1. It unifies the Metrics/MethodLength configuration (which was redundant, as it happens).
  2. It sorts all the cop configurations to be alphabetical.

Check list:

@faisal faisal marked this pull request as draft November 9, 2025 20:42
@faisal
Copy link
Contributor Author

faisal commented Nov 9, 2025

Would we be happier if this were one commit to deal with Metrics/MethodLength and then a second to sort the cops?

@faisal faisal marked this pull request as ready for review December 24, 2025 09:49
Copy link
Contributor

@JuanVqz JuanVqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️ good one!

@faisal faisal mentioned this pull request Dec 29, 2025
3 tasks
@faisal faisal changed the title alphabetize and uniquify cop config in .rubocopy.yml alphabetize and de-duplicate cop config in .rubocopy.yml Dec 29, 2025
@etagwerker etagwerker merged commit e072f19 into whitesmith:main Dec 30, 2025
22 checks passed
@faisal faisal deleted the clean_up_rubocop branch December 30, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants