Skip to content

Fix: Remove encoding from wb open #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weiwei merged 2 commits into from
Jun 23, 2025
Merged

Fix: Remove encoding from wb open #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e00f32
remove encoding from wb open
matthuisman Jun 22, 2025
6034270
bump ver and changelog
matthuisman Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## [4.0.1] - 2025-06-23
### Fixed
- `write_xml` - Remove encoding kwarg to fix `binary mode doesn't take an encoding argument`

## [4.0.0] - 2025-06-22
### Breaking
- Renamed argument `filepath` of methods `write_xml`, `TestSuite.write`, and `JUnitXml.write`
Expand Down
2 changes: 1 addition & 1 deletion junitparser/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
TestSuite,
)

version = "4.0.0"
version = "4.0.1"

__all__ = [
"Attr",
Expand Down
2 changes: 1 addition & 1 deletion junitparser/junitparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def write_xml(obj, file_or_filename: Optional[Union[str, IO]] = None, *, pretty:
xml = parseString(text) # nosec
content = xml.toprettyxml(encoding="utf-8")
if isinstance(file_or_filename, str):
with open(file_or_filename, encoding="utf-8", mode="wb") as xmlfile:
with open(file_or_filename, mode="wb") as xmlfile:
xmlfile.write(content)
else:
if isinstance(file_or_filename, io.TextIOWrapper):
Expand Down
Loading