opencv improves #16
Merged
opencv improves #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a new Windows batch script `build_w_docker.bat` for building OpenCV.js using Docker, including user permissions handling and output directory management. - Updated the existing `build_w_docker.sh` script to improve error handling and ensure proper directory permissions, while aligning the Docker image version with the new batch script. - Modified the OpenCV submodule to update to the latest commit.
…and improve performance. - Commented out console logs in example_image.html, WebARKitCVWorkers.ts, Worker.ts, and WebARKitCoreCV.ts.
kalwalt
added
🚀 enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the build system, updates dependencies, and cleans up logging throughout the codebase. The most significant changes are the upgrade to OpenCV 4.12.0 and Emscripten 3.1.69, enhancements to Docker-based build scripts for cross-platform compatibility, and the removal of verbose console logging in the TypeScript sources.
Dependency and Build System Updates:
Upgraded the OpenCV submodule to version 4.12.0 and updated the Emscripten Docker image to 3.1.69 in all build scripts and CI workflows, along with new build flags to further reduce the final bundle size and disable unnecessary CPU features. (
.github/workflows/build_opencv.yml,opencv,README.md,build_w_docker.sh,build_w_docker.bat) [1] [2] [3] [4] [5]Added a new
build_w_docker.batscript to support building the project on Windows using Docker, improving cross-platform developer experience. (build_w_docker.bat)Documentation Improvements:
README.mdto clarify project goals, update supported OpenCV and Emscripten versions, and provide clearer instructions for building on different platforms. (README.md)Code Cleanliness and Logging:
console.logstatements from the TypeScript source files to reduce noise during development and production runs. (src/Workers/WebARKitCVWorkers.ts,src/Workers/Worker.ts,src/core/WebARKitCoreCV.ts,examples/example_image.html) [1] [2] [3] [4] [5] [6] [7] [8]Build Script Enhancements:
build_w_docker.shand newbuild_w_docker.bat) to handle permissions more robustly, ensure output directories exist, and reliably copy build artifacts to the correct location. (build_w_docker.sh,build_w_docker.bat) [1] [2]