Skip to content
This repository was archived by the owner on Jan 27, 2025. It is now read-only.

Conversation

@mrkshields
Copy link

@mrkshields mrkshields commented Dec 17, 2024

Jira Ticket

N/A (I don't have access to your internal Notion/Jira)

Why

This is a large PR with a huge refactor / new features I spent months to make production ready.

What is changing

  • feat: batch index all techdocs entities to Glean
  • feat: regularly schedule indexing via config
  • feat: configurable datasource
  • fix getTechDocsMetadataUrl, getTechDocsStaticUrl 404 Not Found (wrong url!)
  • feat: implement getTechDocsEntities using native backstage CatalogApi
  • chore: migrate to new backend system
  • chore: upgrade dependencies
  • refactor: Service -> Client
  • feat: GleanDocument, use entityUri for ID to prevent name collisions across different kinds
  • style: Wealthsimple -> Company
  • fix getTechDocsMetadataUrl, getTechDocsStaticUrl Unauthorized (use authentication)
  • chore: lint
  • style: GleanDocument, use entityUri for id and container fields

Checklist

How does this PR handle security?

Uses the native backstage AuthService for authenticating against frontend and backend services, where available.

config.d.ts properly marks entries that are secret as such, hiding them from the UI with plugins such as devtools.

Screenshot

Screenshot 2024-12-17 at 9 37 49 AM

Next steps

@mrkshields mrkshields marked this pull request as ready for review December 17, 2024 14:41
@mrkshields mrkshields requested a review from a team as a code owner December 17, 2024 14:41
@mrkshields mrkshields force-pushed the working-glean-backend-indexer branch from 4a96f45 to 56affdc Compare December 17, 2024 15:37
@mrkshields mrkshields changed the title feat(glean-backend): working indexer feat(glean-backend): TechDocs indexer Dec 17, 2024
@mrkshields mrkshields changed the title feat(glean-backend): TechDocs indexer feat(glean-backend): index all TechDocs-enabled Entities Dec 17, 2024
@mrkshields mrkshields force-pushed the working-glean-backend-indexer branch from 56affdc to b833491 Compare December 18, 2024 17:23
@mrkshields mrkshields force-pushed the working-glean-backend-indexer branch from 66dc37d to 2d49095 Compare January 6, 2025 16:18
@cchawn
Copy link
Contributor

cchawn commented Jan 27, 2025

Hi @beejiujitsu – thanks for the PR! Unfortunately, this project is not actively maintained, as we can't support contributions at this time.

Your related PR in Backstage using your fork of this repo has already been accepted! As a result, I will be closing this PR and archiving the repo to prevent future confusion.

Sorry for the disappointment!

@cchawn cchawn closed this Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants