Disable display_errors in php.ini #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We saw one case of errors appearing in JSON responses breaking their parsing[1]. This commit should disable displaying (in the response) but not disable all reporting[2]. [1] magnusmanske/quickstatements#58 [2] https://stackoverflow.com/a/21699794
Contributor
|
Hm I think we might want this only in production, so we still spot errors in local/staging envs? |
Contributor
Author
|
I think we would probably be ok with this in any environment; as I understand it we will still get errors in all the different environments logs. Locally we probably also don't want deprecation warning polluting supposedly valid json responses |
Contributor
|
true, also this maybe could be a security risk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw one case of errors appearing in JSON responses breaking their parsing[1]. This commit should disable displaying (in the response) but not disable all
reporting[2].
[1] magnusmanske/quickstatements#58
[2] https://stackoverflow.com/a/21699794