Fix: Prevent emoji display race condition #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `_showEmoji` function determined the total number of emojis by inspecting the DOM (`emojiWrapper.children.length`). This could lead to a race condition if an incoming message containing an emoji was processed before the `_initialEmoji` function had fully populated the emojiWrapper. In such cases, `totalEmojiNum` would be 0 (or an incorrect intermediate value), causing valid emojis to be displayed as '[X]'. This commit fixes the issue by setting `totalEmojiNum` to a constant value of 69, which is the actual number of emojis (1.gif to 69.gif) supported by the application. This makes the emoji display logic robust and independent of the DOM state of the emoji panel during message processing. This likely addresses the underlying problem referred to as 'issue #19', where specific emojis might have been reported as not working due to this timing-sensitive bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
_showEmojifunction determined the total number of emojis by inspecting the DOM (emojiWrapper.children.length). This could lead to a race condition if an incoming message containing an emoji was processed before the_initialEmojifunction had fully populated the emojiWrapper. In such cases,totalEmojiNumwould be 0 (or an incorrect intermediate value), causing valid emojis to be displayed as '[X]'.This commit fixes the issue by setting
totalEmojiNumto a constant value of 69, which is the actual number of emojis (1.gif to 69.gif) supported by the application. This makes the emoji display logic robust and independent of the DOM state of the emoji panel during message processing.This likely addresses the underlying problem referred to as 'issue #19', where specific emojis might have been reported as not working due to this timing-sensitive bug.