-
-
Notifications
You must be signed in to change notification settings - Fork 34
feat: add subscriber for wayland #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
08532b4 to
13fe005
Compare
|
Seems the wl_output by other task cannot be used to create new layershell? .. Emm |
009f83e to
80f0e61
Compare
layershellev/src/lib.rs
Outdated
| self.last_wloutput.clone() | ||
| } | ||
| events::LayerOutputSetting::ChosenOutput(output) => self | ||
| .xdg_info_cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.xdg_info_cache in not always populated at this point
Following cycle must be either copied here or moved outside of if is_allscreens statement where it is already present:
for (_, output_display) in &self.outputs {
let zxdgoutput = xdg_output_manager.get_xdg_output(output_display, &qh, ());
self.xdg_info_cache
.push((output_display.clone(), ZxdgOutputInfo::new(zxdgoutput)));
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.xdg_info_cachein not always populated at this point Following cycle must be either copied here or moved outside of ifis_allscreensstatement where it is already present:for (_, output_display) in &self.outputs { let zxdgoutput = xdg_output_manager.get_xdg_output(output_display, &qh, ()); self.xdg_info_cache .push((output_display.clone(), ZxdgOutputInfo::new(zxdgoutput))); }
It should has be added at
https://github.com/waycrate/exwlshelleventloop/pull/86/files#diff-d794182b4533a00f543694b67814cc1ffca93afbc14c08c438cb67f8994c821eR2141-R2208
Emm , I do not think add this logic is good..
c728091 to
dc1ab47
Compare
|
@MalpenZibo I think maybe this pr is quite late, but Finally I seems find a way to solve it. Can you help take a look? Thanks. Or maybe there are other wayland event that you want, place comment here |
just a demo, We need add other information into it
dc1ab47 to
3e0d509
Compare
|
I can check in January! I'll let you know. Anyway I only need a way to get attached monitors |
This pr add a new crate to support listen to the addon of output.
and allow new layershell be add to target output
resolve: #82