add an "add" button when there are no secrets, also add wsh secret ui cli command

[sawka]

No description provided.

[coderabbitai]

Walkthrough

This pull request adds a new secrets UI workflow: a wsh secret ui Cobra subcommand that sends a UI block request (view: "secretstore") via RpcClient, supports a --magnified (-m) flag, and preserves activity tracking around the UI action. Frontend changes update the SecretStore EmptyState component to accept an onAddSecret callback and render an "Add New Secret" button that calls model.startAddingSecret(). Documentation updates expand wsh web docs and add a wsh secret ui usage section in the wsh-reference.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Inspect cmd/wsh/cmd/wshcmd-secret.go for correct Cobra command wiring, flag handling (--magnified), RpcClient payload shape, error wrapping, and deferred activity send.
• Verify frontend/app/view/secretstore/secretstore.tsx: EmptyState signature change, usage sites, and that onAddSecret triggers the intended model action without breaking typings.
• Review docs/docs/wsh-reference.mdx for consistency with CLI flags/behavior (examples for wsh web and wsh secret ui) and note conflicts described for --replace vs --magnified.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check	❓ Inconclusive	No description was provided by the author; this is a lenient check that passes if description relates to changeset in some way, but with no content it cannot be evaluated.	Consider adding a pull request description explaining the motivation and implementation details of these changes.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the two main changes: adding an 'add' button in the empty secrets UI and adding the 'wsh secret ui' CLI command.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch sawka/secretstore-fixes

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5148511 and 48338f3.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (2)

• cmd/wsh/cmd/wshcmd-secret.go (3 hunks)
• docs/docs/wsh-reference.mdx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• docs/docs/wsh-reference.mdx
• cmd/wsh/cmd/wshcmd-secret.go

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Build for TestDriver.ai
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Analyze (go)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}