Skip to content

small changes to wave ai error handling #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 2 commits into from
Nov 4, 2025
Merged

small changes to wave ai error handling #2520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ceb2eb
remove hostname from user facing error in wave ai
sawka Nov 4, 2025
4038881
keep the message that had an error (already added to the backend store)
sawka Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions frontend/app/aipanel/aipanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,12 +243,6 @@ const AIPanelComponentInner = memo(({ onClose }: AIPanelProps) => {
onError: (error) => {
console.error("AI Chat error:", error);
model.setError(error.message || "An error occurred");
setMessages((prevMessages) => {
if (prevMessages.length > 0 && prevMessages[prevMessages.length - 1].role === "user") {
return prevMessages.slice(0, -1);
}
return prevMessages;
});
},
});

Expand Down
18 changes: 17 additions & 1 deletion pkg/aiusechat/openai/openai-backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,22 @@ import (
"github.com/wavetermdev/waveterm/pkg/web/sse"
)

// sanitizeHostnameInError removes the specific hostname from error messages
func sanitizeHostnameInError(err error, baseURL string) error {
if err == nil {
return nil
}

errStr := err.Error()
parsedURL, parseErr := url.Parse(baseURL)
if parseErr == nil && parsedURL.Host != "" {
errStr = strings.ReplaceAll(errStr, baseURL, "AI service")
errStr = strings.ReplaceAll(errStr, parsedURL.Host, "host")
}

return fmt.Errorf("%s", errStr)
}

// ---------- OpenAI wire types (subset) ----------

type OpenAIChatMessage struct {
Expand Down Expand Up @@ -495,7 +511,7 @@ func RunOpenAIChatStep(

resp, err := httpClient.Do(req)
if err != nil {
return nil, nil, nil, err
return nil, nil, nil, sanitizeHostnameInError(err, chatOpts.Config.BaseURL)
}
defer resp.Body.Close()

Expand Down
Loading