Add pull-up for joystick/buttons #10
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current demo, the joystick/button inputs are floating and will result in unreliable "flickering" of the red squares.
Pulling the GPIO pins up using
Pin.PULL_UPwill prevent this flickering. "Up", because looking at the schematic of the V2 version which I have, the buttons are switching to ground. Thus, requiring a pull-up resistor (built-in or not).Also:
Pico_coderepository, which currently is "Waveshrae Pico-OLED/LCD driver code" (notice the incorrect spelling of "Waveshare").