feat: websocket reconnection feature #21
Merged
+567
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/review |
Code Review 📋client_websockets.goIssues Found:
Generated by Prow code-review Plugin at 2025-11-26 16:21:32 WET with the provider openRouter using the model @preset/pipeline-review (preset mode) with response model qwen/qwen3-coder-plus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This web-socket reconnect feature aims to combat a problem that we have with our services that use the omlox-client-go.
Once in a while, our Omlox Hub server closes the active web-socket connections (because of lack of resources, high load, etc.), which makes the services to restart. With this re-connect feature, the client will transparently try to re-establish the web-socket connection and all the subscribed topics based on the default or custom policies. If a re-connection happens successfully, the services don't need to restart, fixing our current problem.