Skip to content

Conversation

@danielvcorreia
Copy link
Contributor

@danielvcorreia danielvcorreia linked an issue Sep 8, 2025 that may be closed by this pull request
2 tasks
@dvcorreia
Copy link
Contributor

If I remember correctly, I left the update methods for a later because there were some quirks that I wasn't sure how to put in code. One example is in the LocationProvider structure. The Type field is mandatory in a location provider, but if we are doing an update that isn't the case. If I read correctly, this happens with the code in this PR.

Nevertheless, this looks good and I think this is a problem that can be solved at a later date. If this gets merged I would ask to open an issue to track this.

@danielvcorreia
Copy link
Contributor Author

danielvcorreia commented Sep 9, 2025

I don't know if I'm understanding correctly, but in the omlox documentation, the required and optional fields in a request body of a POST /providers are the exact same as the request body of a PUT /providers/{provider_id}. In DeepHub's documentation, it is also the same POST /providers PUT /providers/{provider_id}. The only difference is the required path parameter in the PUT method that is absent in the POST method. I tested the case that the path parameter differs from the request's body id field, and in DeepHub's implementation, an error is returned in every case.

@dvcorreia
Copy link
Contributor

I don't know if I'm understanding correctly, but in the omlox documentation, the required and optional fields in a request body of a POST /providers are the exact same as the request body of a PUT /providers/{provider_id}. In DeepHub's documentation, it is also the same POST /providers PUT /providers/{provider_id}. The only difference is the required path parameter in the PUT method that is absent in the POST method. I tested the case that the path parameter differs from the request's body id field, and in DeepHub's implementation, an error is returned in every case.

Seems like I had a wrong idea about the PUT methods, my bad 🙇
This looks good to me, feel free to merge it.

@danielvcorreia danielvcorreia deleted the chore/update-provider-and-trackable branch September 15, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement update trackables and providers methods

2 participants