Issue #6 - Python 3.10 support, bug fixes, and refactoring #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…api would reject results due to the ordering of the data sent to it. Refactored ServiceDelivery.make_xml to not take in a redundant user id. Moved the user id to the environment variables to make it easier to configure and remove the possibility of accidentally committing it to a repo. Reformatted file and imports. Added requirements to the setup and created a requirements.txt file to make it easier to setup. Fixed a problem where errors would not unescape the text so it could contain unreadable content. Added virtual environment paths and files to the git ignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #6
Added support for python 3.9 and 3.10. Fixed problems where the USPS api would reject results due to the ordering of the data sent to it. Refactored ServiceDelivery.make_xml to not take in a redundant user id. Moved the user id to the environment variables to make it easier to configure and remove the possibility of accidentally committing it to a repo. Reformatted file and imports. Added requirements to the setup and created a requirements.txt file to make it easier to setup. Fixed a problem where errors would not unescape the text so it could contain unreadable content. Added virtual environment paths and files to the git ignore.