Skip to content

Conversation

@vshcryabets
Copy link
Owner

No description provided.

@vshcryabets vshcryabets requested a review from Copilot October 28, 2025 20:13
@vshcryabets vshcryabets self-assigned this Oct 28, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the isPullSource() and isPushSource() methods for TestSourceYUV420 and upgrades the build infrastructure to CMake 3.31. The key changes include adding native JNI implementations for source type checking, updating CMake configuration with explicit linker options for symbol inclusion, and adding comprehensive test coverage.

  • Implements isPullSource() and isPushSource() methods in TestSourceYUV420 with JNI bindings
  • Upgrades CMake minimum version to 3.31 with platform-specific linker configurations
  • Adds tests for pull/push source type detection and improves test initialization

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
linux/libs/jnilib/CMakeLists.txt Updates CMake version to 3.31 and adds platform-specific linker flags for forcing symbol inclusion
linux/apps/gtk_preview/CMakeLists.txt Removes commented-out code reference
libausbc/src/test/java/com/vsh/source/TestSourceYUV420Tests.kt Adds tests for isPullSource() and isPushSource(), ensures source is opened before testing
libausbc/src/test/java/com/vsh/source/PullToPushSourceTests.kt Refactors test to use real TestSourceYUV420 instead of anonymous mock object and fixes parameter name
libausbc/src/main/jni/modules/sources/src/jni/JniTestSource.cpp Adds native implementations for isPullSource() and isPushSource(), removes commented registration code
libausbc/src/main/jni/modules/sources/src/jni/JniSources.cpp Removes call to deleted JniTestSource_register() function
libausbc/src/main/jni/modules/sources/include/jni/JniTestSource.h Removes declaration of deleted JniTestSource_register() function
libausbc/src/main/java/com/vsh/source/TestSourceYUV420.kt Implements isPullSource() and isPushSource() with JNI calls and adds native method declarations
libausbc/src/main/java/com/vsh/source/PullToPushSource.kt Adds error message to orElseThrow() for better diagnostics
libausbc/build.gradle.kts Updates CMake configuration syntax and adds version specification
libausbc/CMakeLists.txt Updates minimum required CMake version to 3.31
gradle/libs.versions.toml Adds CMake version 3.31.6 to version catalog
README.md Adds build instructions with CMake and NDK version requirements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vshcryabets vshcryabets marked this pull request as ready for review October 28, 2025 20:35
@vshcryabets vshcryabets merged commit 13d20ee into master Oct 28, 2025
1 check passed
@vshcryabets vshcryabets deleted the fix/update-test-sources branch October 28, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants