-
Notifications
You must be signed in to change notification settings - Fork 7
UAC code for Linxu host #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the UAC code for the Linux host, with modifications to header inclusions, source file paths, and IDE settings.
- Removed an unused header inclusion in JniJpegBenchmark.cpp.
- Changed the include style for turbojpeg in ImageUseCases.cpp.
- Updated file path references in CMakeLists.txt to reflect a reorganization into the src/ directory.
- Extended VS Code settings for additional C++ configurations.
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| libausbc/src/main/jni/UVCCamera/src/JniJpegBenchmark.cpp | Removed an unnecessary header inclusion. |
| libausbc/src/main/jni/UVCCamera/src/ImageUseCases.cpp | Updated turbojpeg include directive from angle brackets to quotes. |
| libausbc/src/main/jni/UVCCamera/CMakeLists.txt | Adjusted source file paths to use the new src/ directory structure. |
| .vscode/settings.json | Expanded configuration for additional C++ keywords and types. |
| #endif | ||
| #ifdef USE_TURBOJPEG | ||
| #include <turbojpeg.h> | ||
| #include "turbojpeg.h" |
Copilot
AI
May 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify whether the change from angle brackets to quotes for turbojpeg is intentional. If turbojpeg is provided as a system library, consider using angle brackets for clarity.
| #include "turbojpeg.h" | |
| #include <turbojpeg.h> |
| ${UVCCAMERA}/src/JniUVCCamera.cpp | ||
| ${UVCCAMERA}/src/JpegBenchmark.cpp | ||
| ${UVCCAMERA}/src/LoadJpegImageFromAssetsUseCase.cpp | ||
| ${UVCCAMERA}/src/JniJpegBenchmark.cpp |
Copilot
AI
May 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the updated file paths in the CMakeLists.txt accurately reflect the new directory layout and that no outdated references remain.
| ${UVCCAMERA}/src/JniJpegBenchmark.cpp | |
| # Assuming the file has been removed from the project: | |
| # Remove the reference to JniJpegBenchmark.cpp | |
| # If the file has been moved, replace the path with the correct one. | |
| # Example if the file has been moved to a new location: | |
| # ${UVCCAMERA}/new_path/JniJpegBenchmark.cpp | |
| # Example if the file has been removed: | |
| # (Remove the line entirely) |
No description provided.