Skip to content

Conversation

@vshcryabets
Copy link
Owner

No description provided.

@vshcryabets vshcryabets self-assigned this May 17, 2025
@vshcryabets vshcryabets requested a review from Copilot May 17, 2025 18:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the UAC code for the Linux host, with modifications to header inclusions, source file paths, and IDE settings.

  • Removed an unused header inclusion in JniJpegBenchmark.cpp.
  • Changed the include style for turbojpeg in ImageUseCases.cpp.
  • Updated file path references in CMakeLists.txt to reflect a reorganization into the src/ directory.
  • Extended VS Code settings for additional C++ configurations.

Reviewed Changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated 2 comments.

File Description
libausbc/src/main/jni/UVCCamera/src/JniJpegBenchmark.cpp Removed an unnecessary header inclusion.
libausbc/src/main/jni/UVCCamera/src/ImageUseCases.cpp Updated turbojpeg include directive from angle brackets to quotes.
libausbc/src/main/jni/UVCCamera/CMakeLists.txt Adjusted source file paths to use the new src/ directory structure.
.vscode/settings.json Expanded configuration for additional C++ keywords and types.

#endif
#ifdef USE_TURBOJPEG
#include <turbojpeg.h>
#include "turbojpeg.h"
Copy link

Copilot AI May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify whether the change from angle brackets to quotes for turbojpeg is intentional. If turbojpeg is provided as a system library, consider using angle brackets for clarity.

Suggested change
#include "turbojpeg.h"
#include <turbojpeg.h>

Copilot uses AI. Check for mistakes.
${UVCCAMERA}/src/JniUVCCamera.cpp
${UVCCAMERA}/src/JpegBenchmark.cpp
${UVCCAMERA}/src/LoadJpegImageFromAssetsUseCase.cpp
${UVCCAMERA}/src/JniJpegBenchmark.cpp
Copy link

Copilot AI May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the updated file paths in the CMakeLists.txt accurately reflect the new directory layout and that no outdated references remain.

Suggested change
${UVCCAMERA}/src/JniJpegBenchmark.cpp
# Assuming the file has been removed from the project:
# Remove the reference to JniJpegBenchmark.cpp
# If the file has been moved, replace the path with the correct one.
# Example if the file has been moved to a new location:
# ${UVCCAMERA}/new_path/JniJpegBenchmark.cpp
# Example if the file has been removed:
# (Remove the line entirely)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants