Replace syslog #13
Closed
Replace syslog #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.4 started use singlequote instead of opening backtick in the
error messages [[1]]. This exhibited in error:
~~~
2) ABRT handles exception in 'abrt.rb' with RubyGems enabled
Failure/Error:
expect { system "ruby --disable-gems -rrubygems #{abrt_rb}" }
.to output(/\A\Z/).to_stdout_from_any_process
.and output(output_message_pattern).to_stderr_from_any_process
expected block to output /\A\/mnt\/abrt\/spec\/..\/lib\/abrt.rb:\d+:in `<main>': can't modify frozen Array(: \[1, 2, 3\])? \((FrozenError|RuntimeError)\)\n\Z/ to stderr, but output "/mnt/abrt/spec/../lib/abrt.rb:15:in '<main>': can't modify frozen Array: [1, 2, 3] (FrozenError)\n"
Diff for (output /\A\/mnt\/abrt\/spec\/..\/lib\/abrt.rb:\d+:in `<main>':...):
@@ -1 +1 @@
-/\A\/mnt\/abrt\/spec\/..\/lib\/abrt.rb:\d+:in `<main>': can't modify frozen Array(: \[1, 2, 3\])? \((FrozenError|RuntimeError)\)\n\Z/
+/mnt/abrt/spec/../lib/abrt.rb:15:in '<main>': can't modify frozen Array: [1, 2, 3] (FrozenError)
# ./spec/abrt_spec.rb:16:in 'block (3 levels) in <top (required)>'
~~~
[1]: https://bugs.ruby-lang.org/issues/16495
`syslog` used to be part of StdLib. But beginning with Ruby 3.4, it was extracted into default gems. This is problematic when Ruby is executed with `--disable-gems`, because there is no easy way to require `syslog`. Therefore, this commit introduces custom `UtilLinuxLogger`. This use `logger` command from util-linux and implemnts just minimal `Syslog` interface required. While this could have been used just as a fallback, when `syslog` can't be required, it will be easier to use it every time. Fixes #12
Owner
Author
|
Obsolete by #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use custom
UtilLinuxLoggerinsteadsyslogsyslogused to be part of StdLib. But beginning with Ruby 3.4, it was extracted into default gems. This is problematic when Ruby is executed with--disable-gems, because there is no easy way to requiresyslog.Therefore, this commit introduces custom
UtilLinuxLogger. This useloggercommand from util-linux and implemnts just minimalSysloginterface required.While this could have been used just as a fallback, when
syslogcan't be required, it will be easier to use it every time.Fixes #12