Checkpoint feedback #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 19, 2017
src/string.js
Outdated
| toCurrency() { | ||
| if (!Number(this)) { | ||
| return 'This is not a Number'; | ||
| if (/[^\d.]/.test(this) || /\..*\./.test(this)) { |
There was a problem hiding this comment.
Trailing spaces not allowed no-trailing-spaces
houndci-bot
reviewed
Jan 19, 2017
| /* eslint no-unused-expressions: 0 */ | ||
| const mocha = require('mocha'); | ||
| const expect = require('chai').expect; | ||
| const chai = require('chai'); |
There was a problem hiding this comment.
Unable to resolve path to module 'chai' import/no-unresolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolves all feedback received from the facilitator during checkpoint defense
Description of Task to be completed?
Refactor the isQuestion() , toCurrency() and fromCurrency() methods
How should this be manually tested?
By comparing the methods before and after the implementations
Any background context you want to provide?
Not applicable
What are the relevant pivotal tracker stories?
Not applicable
Screenshots (if appropriate)
Not applicable
Questions:
Not applicable