Skip to content

Conversation

@Daribon
Copy link
Contributor

@Daribon Daribon commented Sep 17, 2022

🍰 Pullrequest

All landmines are currently spawned in incorrect positions and were all spawned by hand badly.
This PR deletes all current landmines and respawns all of them using sniff positions.

You can change the guids to whatever you find fitting, just used guids I knew were empty.

Proof

WoW_3XVXcAXnr8
WoW_8tv5lnWXUq

Issues

  • None

How2Test

  • Enter Alterac Valley.

Todo / Checklist

  • None

@Wall-core
Copy link
Contributor

Wall-core commented Oct 9, 2022

The changing of landmine GUIDs has impacted battleground_event (event 100 & 101, for minelayers). The GUIDs no longer exist as they were changed.

image

@Daribon
Copy link
Contributor Author

Daribon commented Oct 10, 2022

I realized what the issue was. I forgot to add the guids to gameobject_battleground.
A fix will be coming soonish.

@Daribon
Copy link
Contributor Author

Daribon commented Oct 20, 2022

Fixed the error that Wall reported.

The only issue that remains with the landmines is that they will show up as Bloodscalp Panther in combat log when invisible.
It is not a bug with the PR and the bug existed prior to this PR.
image

@ShiyoKozuki
Copy link
Contributor

Fixed the error that Wall reported.

The only issue that remains with the landmines is that they will show up as Bloodscalp Panther in combat log when invisible. It is not a bug with the PR and the bug existed prior to this PR. image

dc3c752
Did this commit fix that?

@Daribon
Copy link
Contributor Author

Daribon commented Dec 22, 2023

Fixed the error that Wall reported.
The only issue that remains with the landmines is that they will show up as Bloodscalp Panther in combat log when invisible. It is not a bug with the PR and the bug existed prior to this PR. image

dc3c752 Did this commit fix that?

no

@0blu 0blu added the SQL A issue / PR which references SQL code label Oct 22, 2024
@Daribon Daribon closed this by deleting the head repository Dec 9, 2025
@Daribon
Copy link
Contributor Author

Daribon commented Dec 9, 2025

Will be handled in #3029.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SQL A issue / PR which references SQL code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants