Skip to content

fix(hmr): reload when components switch between vapor and vdom #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edison1105 merged 4 commits into from
Dec 12, 2025
+3 −0
Merged

fix(hmr): reload when components switch between vapor and vdom #714

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a7de51
fix(plugin-vue): ensure template-only components hmr correctly switch…
edison1105 Dec 9, 2025
7415d9d
chore: tweaks
edison1105 Dec 9, 2025
48f1fff
chore: tweaks
edison1105 Dec 9, 2025
c9e8df8
chore: tweaks
edison1105 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/plugin-vue/src/handleHotUpdate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,9 @@ function isEqualAst(prev?: t.Statement[], next?: t.Statement[]): boolean {
}

function hasScriptChanged(prev: SFCDescriptor, next: SFCDescriptor): boolean {
// @ts-expect-error TODO remove when 3.6 is out
if (prev.vapor !== next.vapor) return true
Comment on lines +299 to +300
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new vapor mode detection logic lacks test coverage. While the playground has HMR tests for various scenarios, there are no tests verifying that the component reloads correctly when switching between vapor and vdom modes. Consider adding a test case that validates this behavior by toggling a component between vapor and non-vapor modes and verifying that HMR triggers a full reload rather than just a hot update.

Copilot uses AI. Check for mistakes.

// check for scriptAst/scriptSetupAst changes
// note that the next ast is not available yet, so we need to trigger parsing
const prevScript = getResolvedScript(prev, false)
Expand Down
Loading