Update sort order when adding attributes #590
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
Deploy preview looks like it is working great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #576
Give a longer description of what this PR addresses and why it's needed
This PR fixes #576 by updating the sort order function within the sidebar 'updateAttributes'. The issue was that the use case where both
aandbwere included inUPSET_ATTS(degree, deviation), the first comparator (deviationwhen it was already present in the plot) was always being sorted first. This resulted in the formatting rules returning a-1 * offsetand breaking the formatting for deviation.Provide pictures/videos of the behavior before and after these changes (optional)
See #576 for before
Have you added or updated relevant tests?
Have you added or updated relevant documentation?