new features and rebranding of classes #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camarasu
reviewed
Apr 24, 2025
src/vip_client/classes/VipSession.py
Outdated
|
|
||
| # Clean session data on VIP | ||
| def finish(self, timeout=300) -> VipSession: | ||
| def finish(self, timeout=300, keep_output=False) -> VipSession: |
Member
There was a problem hiding this comment.
A similar keep_inputs option would be also useful.
In this case, if inputs and/or outputs are not removed by the finish method, we need to provide a remove/delete_folder allowing users to clean-up data at a later moment in time.
Contributor
Author
There was a problem hiding this comment.
The option keep_input was added in this commit.
The user can delete inputs/outputs later by recreating a session with the same name and calling finish() without options (it's in the doc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a breakdown of the PR:
VipClientandVipLoaderare deletedVipCIbecomeVipGirderVipGirder, you can choose to upload the result directly on VIP and not on girderVipGirderhas new download_outputs() function (only from output that are located on VIP)VipGirderandVipSessioncan now do finish without deleting results on VIP.