Skip to content

Conversation

@penguinland
Copy link
Contributor

I went with 0.70.0, released last week. This week's release has already needed a patch (and may or may not need more patches).

Everything compiles and the tests pass, but I am unsure how to actually try running it outside of production. but I kinda imagine that if it compiles, it probably still works.

The Camera interface lost its streaming capability, so I changed to use .Image() to get frames instead. We often seem to use jpegs, which confuses me because it's a lossy format. So, I'm using PNGs. The interface looks like it ought to be format-agnostic, but that does seem like something we need to try out (perhaps in an RC before a "real" release).

@penguinland penguinland requested a review from bhaney April 16, 2025 21:17
go.viam.com/rdk v0.50.0
go.viam.com/test v1.2.3
go.viam.com/utils v0.1.113
go.viam.com/rdk v0.70.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only line in this file I changed manually. All the rest of the changes (including line 3) came from running go mod tidy. 🤷

Copy link
Collaborator

@bhaney bhaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to jpeg and use the convenience function rather than decoding the image yourself

@bhaney
Copy link
Collaborator

bhaney commented Apr 17, 2025

The size differences between jpeg and png can be gigantic- sometimes like 10x the size depending. Over grpc these image transfers slow our programs down considerably

@penguinland
Copy link
Contributor Author

TIL, thanks!

Take another look. I also updated the makefile so it rebuilds the module every time the source code changes. Without that, you need to delete the old module before make will build it again.

Copy link
Collaborator

@bhaney bhaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
do click the "re-request review" button though in the future, as I have set up slack notifications to ping me when I have pending reviews to do

@penguinland penguinland merged commit 3a4ff8e into viam-modules:main Apr 17, 2025
1 check passed
@penguinland penguinland deleted the update_sdk branch April 17, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants