ARC-3282: Add generic method to update material request status #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertyhell
approved these changes
Jan 9, 2026
| 'Set the status of the material request to pending when a maintainer has viewed the request', | ||
| }) | ||
| @RequireAnyPermissions(Permission.VIEW_ANY_MATERIAL_REQUESTS) | ||
| public async processMaterialRequest( |
Contributor
There was a problem hiding this comment.
Suggested change
| public async processMaterialRequest( | |
| public async setMaterialRequestStatusToPending( |
| ) { | ||
| update_app_material_requests( | ||
| where: { id: { _eq: $materialRequestId }, profile_id: { _eq: $userProfileId } } | ||
| where: { id: { _eq: $materialRequestId } } |
Contributor
There was a problem hiding this comment.
this extra check on profile id, is to make sure users can only update their own material request
if you remove that here, you need to manually check in the controller if the current user should be allowed to modify this material request.
| } | ||
|
|
||
| public async updateMaterialRequestStatus( | ||
| currentRequest: MaterialRequest, |
Contributor
There was a problem hiding this comment.
doesn't it make more sense to only pass the currentRequest.id
and then set the updateMaterialRequest specific date based on the desired status?
const updateMaterialRequest = {
materialRequestId: currentRequest.id,
updated_at: new Date().toISOString(),
};
if (status === status === Lookup_App_Material_Request_Status_Enum.Cancelled) {
updateMaterialRequest.cancelled_at = new Date().toISOString();
}
if (status === status === Lookup_App_Material_Request_Status_Enum.Approved) {
updateMaterialRequest.approved_at = new Date().toISOString();
}
if (status === status === Lookup_App_Material_Request_Status_Enum.Denied) {
updateMaterialRequest.denied_at = new Date().toISOString();
}
const updateMaterialRequestStatusResponse = await this.dataService.execute<
UpdateMaterialRequestStatusMutation,
UpdateMaterialRequestStatusMutationVariables
>(UpdateMaterialRequestStatusDocument, {
materialRequestId: currentRequestId,
updateMaterialRequest,
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues on #572