Add Maven wrapper #3096
Merged
Add Maven wrapper #3096
+550
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kressi
force-pushed
the
maven-wrapper
branch
from
a6a30f3 to
4af9b7e
Compare
pivovarit
force-pushed
the
maven-wrapper
branch
from
4af9b7e to
aeeba1d
Compare
Member
|
I'm all for it, but one question remains - will this make GitHub Actions install Maven on every build first? 🤔 |
Contributor
Author
|
Yes, only .m2/repository is being cached. It does not look like cache can easily be extended with additional paths. I think setting up cache for |
Member
|
Yes, let's try |
kressi
force-pushed
the
maven-wrapper
branch
from
aeeba1d to
53dd34a
Compare
Contributor
Author
|
Pushed with |
Member
|
please also sync with the main branch - this should be easy (just accept what's on main and replace commands with wrapper) |
kressi
force-pushed
the
maven-wrapper
branch
from
53dd34a to
f9dbfb9
Compare
kressi
force-pushed
the
maven-wrapper
branch
from
f9dbfb9 to
976a849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since not everyone has/wants Maven locally installed, I'm proposing to add Maven wrapper to the project. Additionally, this ensures the project is built with the desired Maven version.