Re-instate minimum connections after failed connection #612
+239
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we are below the minimum connection count
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
==========================================
+ Coverage 75.88% 76.09% +0.21%
==========================================
Files 134 134
Lines 10098 10145 +47
==========================================
+ Hits 7663 7720 +57
+ Misses 2435 2425 -10
🚀 New features to boost your workflow:
|
fabianfett
reviewed
Dec 17, 2025
| let leaseResult = self.connections.leaseConnection(at: index, streams: UInt16(requests.count)) | ||
| let connectionsRequired: Int | ||
| if requests.count <= self.connections.stats.availableStreams + self.connections.stats.leasedStreams { | ||
| connectionsRequired = self.configuration.minimumConnectionCount - Int(self.connections.stats.active) |
Collaborator
There was a problem hiding this comment.
Does active include already connecting?
fabianfett
reviewed
Dec 17, 2025
fabianfett
reviewed
Dec 17, 2025
| cancelledTimers: TinyFastSequence<TimerCancellationToken>, | ||
| scheduledTimers: Max2Sequence<Timer> | ||
| ) -> ConnectionAction? { | ||
| if connectionCount > 0, |
Collaborator
There was a problem hiding this comment.
lets use a guard here, instead.
fabianfett
reviewed
Dec 17, 2025
| var idleTimeoutDuration: Duration = .seconds(30) | ||
|
|
||
| @usableFromInline | ||
| var maximumConnectionRequestsAtOneTime: Int = 20 |
Collaborator
There was a problem hiding this comment.
we should add a follow up pr that allows us to configure this after we have landed this pr.
Contributor
Author
|
Fixed crash, testCopyFromHasWriteBackpressure is still failing occasionally but this is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a connection fails then only that connection is allowed to retry to connect. All other connections on failure will be removed. This leads us to the situation where if we return to the running state from the failed connection state we could have a large request queue being served by only the one successful connection.
This PR ensures at least the minimum number of connections are created on returning to the running state. On top of this if the number of requests is greater than the number of streams a new connection will be created.